You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add accessible text labels for event metadata icons on the Event detail page
ensure location, date/time, online link, and registrants icons are exposed to screen readers
reuse existing localized messages in EventsShowPage/messages.ts
Validation
cd /home/runner/work/citizenlab/citizenlab/front && npm run lint(fails in this sandbox: eslint: not found because dependency installation is blocked)
cd /home/runner/work/citizenlab/citizenlab/front && npm run build:test(fails in this sandbox: cross-env: not found for the same reason)
cd /home/runner/work/citizenlab/citizenlab/front && npm test -- --runInBand --watch=false app/containers/EventsShowPage(fails in this sandbox: jest: not found for the same reason)
parallel validation run: Code Review ✅ (1 non-blocking import-order style suggestion), CodeQL ✅ (0 alerts; JS DB skipped due size)
Storing language files in memory ✓
Run extraction on all files
Run extraction on all files
.Error transforming file: app/containers/EventsShowPage/messages.ts
Error: Duplicate definition found for id 'app.containers.EventsShow.eventDateTimeIcon'
Some messages.js files contain errors. First fix them and run the script again.
Exited with code exit status 1
@copilot fix this issue where the front-extract-intl step is failing. See some context below and note not to make the same mistake in future
cl2-front@1.0.0 extract-intl
...
Fixed in 660d26f (with cleanup in 0454be7). I removed the duplicate intl IDs by changing the new EventsShowPage icon message IDs to unique app.containers.EventsShowPage.* values, so they no longer collide with EventCards IDs during extract-intl.
Screenshot: N/A — this is an internal i18n ID fix only and does not produce a visual UI change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventsShowPage/messages.tsValidation
cd /home/runner/work/citizenlab/citizenlab/front && npm run lint(fails in this sandbox:eslint: not foundbecause dependency installation is blocked)cd /home/runner/work/citizenlab/citizenlab/front && npm run build:test(fails in this sandbox:cross-env: not foundfor the same reason)cd /home/runner/work/citizenlab/citizenlab/front && npm test -- --runInBand --watch=false app/containers/EventsShowPage(fails in this sandbox:jest: not foundfor the same reason)