TAN-7561 User search with special letters + refactoring#13699
Open
sebastienhoorens wants to merge 4 commits intomasterfrom
Open
TAN-7561 User search with special letters + refactoring#13699sebastienhoorens wants to merge 4 commits intomasterfrom
sebastienhoorens wants to merge 4 commits intomasterfrom
Conversation
The previous regex (\W) stripped non-ASCII characters like ø, é, ñ from
mention search queries, breaking user search for names with special
characters. Replace with \p{L} to preserve Unicode letters, apostrophes,
hyphens, and spaces.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move user search logic out of the mentions controller and mention service into a dedicated UserSearchService. This consolidates query sanitization, idea participant prioritization, and role filtering into a single service with a clean interface. - Replace roles[] param with moderators_only boolean (simpler API) - Use admin_or_moderator scope (covers folder/space moderators too) - Reuse ParticipantsService for idea participant lookup - Apply .active scope consistently across both search tiers - Add comprehensive service spec (Unicode, idea context, moderators) - Simplify controller from 58 to 21 lines Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The gsub was a leftover from a 2020 slug-to-pg_search migration. pg_search already sanitizes tsquery special characters internally via DISALLOWED_TSQUERY_CHARACTERS, so the extra sanitization was redundant. Added a spec to confirm special characters are handled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed