Skip to content

Conversation

@cforgaci
Copy link
Contributor

@cforgaci cforgaci commented Jul 11, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

I tried here to change the output of delineate() from a list to an S3 object of class delineation and use that to create a plot() method. Now, plot() is not that elegant, nor is it very customizable, but it provides a quick way to the user to examine the output of delineate().

I would also consider this in the context of #262, following your suggestion to refactor delineate(). If data retrieval is moved out from delineate(), then the plot method proposed here needs to be rethought as well. I do think we should move forward with #262, so I am okay with adjusting or dropping this after that.

Related Issues

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Added entry in changelog?

For user-facing changes, add a line describing the changes in NEWS.md

  • Yes

@cforgaci cforgaci requested a review from fnattino July 11, 2025 21:13
@cforgaci cforgaci changed the title 258 delination class cf delineate() returns delineation class + plot() method Jul 11, 2025
@cforgaci cforgaci changed the title delineate() returns delineation class + plot() method delineate() returns delineation class + plot() method Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants