delineate() returns delineation class + plot() method
#263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I tried here to change the output of
delineate()from a list to an S3 object of classdelineationand use that to create aplot()method. Now,plot()is not that elegant, nor is it very customizable, but it provides a quick way to the user to examine the output ofdelineate().I would also consider this in the context of #262, following your suggestion to refactor
delineate(). If data retrieval is moved out fromdelineate(), then the plot method proposed here needs to be rethought as well. I do think we should move forward with #262, so I am okay with adjusting or dropping this after that.Related Issues
delineate()returns object of classdelineation#258delineate()returns base layers in delineation object #259 Implement aplot()method for objects of classdelineation#260 Move data retrieval out ofdelineate()#262delineate()returns object of classdelineation#258delineate()returns base layers in delineation object #259 Implement aplot()method for objects of classdelineation#260Added/updated tests?
have not been included
Added entry in changelog?
For user-facing changes, add a line describing the changes in NEWS.md