Skip to content

Enable exclusion of specified dates from date ranges#259

Merged
aharpalaniTO merged 22 commits intodeployfrom
date-exclusion
Apr 8, 2026
Merged

Enable exclusion of specified dates from date ranges#259
aharpalaniTO merged 22 commits intodeployfrom
date-exclusion

Conversation

@Nate-Wessel
Copy link
Copy Markdown
Member

@Nate-Wessel Nate-Wessel commented Mar 19, 2026

This will allow the app to optionally accept a set of dates to exclude from the aggregations per date range.

Quite a few little features had to be modified to enable this without creating any reversions on other features:

  • daysInRange calculations
  • an additional URI GET parameter + query logic
  • cache/store retrieved results in a map keyed by URI (to break cache if URI changes)
  • new editing controls on the DateRange factors
  • consideration of these new params in reconstruction from URIs in a file
  • add asterisk in DateRange name as necessary with corresponding notes in the output

@Nate-Wessel Nate-Wessel self-assigned this Mar 19, 2026
@Nate-Wessel Nate-Wessel added front-end back-end new feature python Pull requests that update python code javascript Pull requests that update javascript code labels Mar 19, 2026
@Nate-Wessel Nate-Wessel linked an issue Mar 20, 2026 that may be closed by this pull request
@Nate-Wessel Nate-Wessel requested a review from gabrielwol March 23, 2026 17:15
@Nate-Wessel
Copy link
Copy Markdown
Member Author

@gabrielwol, I'm still doing work on the frontend of the app, but the part I'd like you to review (please and thanks!) should be stable now.

Please have a look if you would at just the changed python files in the backend/ directory.

The changes there enable a new optional GET argument like

http://localhost:8072/aggregate-travel-times/30415357/30415343/2/5/2026-03-02/2026-03-09/true/1234567?excludeDates=2026-03-04

http://localhost:8072/aggregate-travel-times/30415357/30415343/2/5/2026-03-02/2026-03-09/true/1234567?excludeDates=2026-03-04,2026-03-05

etc

@Nate-Wessel Nate-Wessel changed the title Accept user-supplied list of excluded dates Enable exclusion of specified dates from date ranges Mar 23, 2026
@gabrielwol
Copy link
Copy Markdown

Looks good to me!

@Nate-Wessel Nate-Wessel marked this pull request as ready for review March 24, 2026 14:03
@Nate-Wessel Nate-Wessel removed the request for review from gabrielwol April 1, 2026 16:20
Copy link
Copy Markdown
Contributor

@aharpalaniTO aharpalaniTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will approve and merge. Would consider including excluded dates in its own field rather than in the notes field of the output file.

@aharpalaniTO aharpalaniTO merged commit 95af385 into deploy Apr 8, 2026
1 check passed
@aharpalaniTO aharpalaniTO deleted the date-exclusion branch April 8, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-end front-end javascript Pull requests that update javascript code new feature python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to filter certain dates in query

3 participants