Major looping and modbus read re-write.#37
Open
mcsarge wants to merge 2 commits intoClassicDIY:masterfrom
Open
Major looping and modbus read re-write.#37mcsarge wants to merge 2 commits intoClassicDIY:masterfrom
mcsarge wants to merge 2 commits intoClassicDIY:masterfrom
Conversation
bclermont
reviewed
Jul 26, 2023
| valid = false; | ||
| } | ||
| int rate = _webServer.arg(wakePublishRateParam.getId()).toInt() * 1000; | ||
| // long mqttServerParamLength = _webServer.arg(mqttServerParam.getId()).length(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I have reworked the looping to call for a publish periodically. The wake publish rate is limited to not fater than every 5 seconds. When publish time comes around, the buffer flags are cleared and an attempt is made to fill them again. Once filled, the data is published to mqtt. Only one modbus async read is allowed at a time. So when multiple reads need to be done, that are done sequentially. If the modbus read does not return or errors out the publish does not happen. There is a timer that will clear the modbus read flag if the read never returns or errors out as a safety.