Skip to content

KraftLogger - Logger IsEnabled is thread-safe #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KraftLogger - Logger IsEnabled is thread-safe #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/KraftLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,7 @@ public bool IsEnabled(Microsoft.Extensions.Logging.LogLevel logLevel)
/// </summary>
private static bool IsEnabled(NLog.LogLevel logLevel)
{
if (_Logger != null)
{
lock (_Logger)
{
return _Logger.IsEnabled(logLevel);
}
}
return false;
return _Logger?.IsEnabled(logLevel) ?? false;
}

/// <summary>
Expand Down
6 changes: 3 additions & 3 deletions src/KraftLoggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ namespace Ccf.Ck.Libs.Logging
{
public class KraftLoggerProvider : ILoggerProvider
{
readonly Logger _Logger;
readonly IHttpContextAccessor _Accessor;
private IWebHostEnvironment _WebHostEnvironment;
private readonly Logger _Logger;
private readonly IHttpContextAccessor _Accessor;
private readonly IWebHostEnvironment _WebHostEnvironment;
public KraftLoggerProvider(Logger logger, IHttpContextAccessor accessor, IWebHostEnvironment env)
{
_Logger = logger;
Expand Down