Skip to content

Enforce config.json presence when userConfig is enabled #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cleboost wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enforce config.json presence when userConfig is enabled #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5bf2ff
fix: enforce config.json presence at startup and build time
Cleboost Mar 26, 2026
4e6643a
fix: enforce config.json presence and fix linting issues
Cleboost Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/dev/commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,12 @@ ${
if (await configFile.exists()) {
userConfigData = await configFile.json();
} else {
console.warn("⚠️ config.json not found at runtime");
console.error("❌ config.json not found at runtime");
process.exit(1);
}
} catch (e) {
console.error("❌ Failed to load config.json:", e);
process.exit(1);
}
const client = new DjsClient<UserConfig>({ djsConfig: config, userConfig: userConfigData as UserConfig });`
: " const client = new DjsClient({ djsConfig: config });"
Expand Down Expand Up @@ -427,10 +429,11 @@ export function registerBuildCommand(cli: CAC) {
try {
await fs.copyFile(configJsonPath, outConfigJsonPath);
console.log(
pc.green("✓") + ` config.json copied to ${pc.bold("dist/")}`,
`${pc.green("✓")} config.json copied to ${pc.bold("dist/")}`,
);
} catch (e) {
console.warn(pc.yellow("⚠️ Could not copy config.json to dist/"));
} catch (_e) {
console.error(pc.red("❌ Could not copy config.json to dist/"));
process.exit(1);
}
}

Expand Down
7 changes: 3 additions & 4 deletions packages/dev/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,10 @@ export async function runBot(projectPath: string) {
userConfig = JSON.parse(configJsonContent);
console.log(`${pc.green("✓")} User config loaded`);
} catch (_error) {
console.warn(
pc.yellow(
"⚠️ userConfig is enabled but config.json not found or invalid",
),
console.error(
pc.red("❌ userConfig is enabled but config.json not found or invalid"),
);
process.exit(1);
}
}

Expand Down