Master #8
Open
Master #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing resetSubscription function with mx7 compatible version
ChrisdeG
approved these changes
Mar 2, 2018
Contributor
|
Hi Eric, The boolean support does not handle the click events well at the moment. Do you have a solution for that? Chris |
Contributor
Author
|
Sorry about that. I added booleans like a year ago and was really focused on the fix for mx7 when I submitted the PR. Looks like you got this figured out?
… On Mar 2, 2018, at 5:56 AM, ChrisdeG ***@***.***> wrote:
Hi Eric,
The boolean support does not handle the click events well at the moment. Do you have a solution for that?
Chris
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADxvK4LNmzMccFo5Fzf6sn7_xvW5kdDHks5taSVDgaJpZM4SZGO6>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing resetSubscription function with mx7 compatible version