-
Notifications
You must be signed in to change notification settings - Fork 16
Simpler horizontal remapping methods for diagnostics #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dc8facd to
bb81b40
Compare
2bbd332 to
5b876f1
Compare
modified: docs/src/remapping.md modified: src/Remapping/distributed_remapping.jl modified: src/Remapping/interpolate_array.jl modified: src/Remapping/remapping_utils.jl modified: test/Remapping/distributed_remapping.jl modified: test/Remapping/interpolate_array.jl
modified: src/Remapping/distributed_remapping.jl modified: src/Remapping/interpolate_array.jl modified: test/Remapping/distributed_remapping.jl modified: test/Remapping/interpolate_array.jl
ph-kev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests in ClimaDiagnostics are failing because a default wasn't provided for horizontal_method in the Remapper object?
I think someone who know more about the math of interpolation should look at this too.
in ClimaDiagnostics) modified: docs/src/remapping.md
Thanks @ph-kev : API has been updated to fix downstream failures - and struct properties updated in |

Enables simpler bilinear interpolation option (see ClimaInterpolations.jl) within the Remapping module.
Example:
