Skip to content

Conversation

@akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented Feb 4, 2026

Enables simpler bilinear interpolation option (see ClimaInterpolations.jl) within the Remapping module.

Example:
Screenshot 2026-02-04 at 1 16 01 PM

@akshaysridhar
Copy link
Member Author

Nq = 2 ; e.g.
Screenshot 2026-02-06 at 4 14 01 PM

@akshaysridhar akshaysridhar force-pushed the as/bilinear-horizontal-interp branch 3 times, most recently from dc8facd to bb81b40 Compare February 9, 2026 17:53
@akshaysridhar akshaysridhar force-pushed the as/bilinear-horizontal-interp branch from 2bbd332 to 5b876f1 Compare February 9, 2026 17:57
	modified:   docs/src/remapping.md
	modified:   src/Remapping/distributed_remapping.jl
	modified:   src/Remapping/interpolate_array.jl
	modified:   src/Remapping/remapping_utils.jl
	modified:   test/Remapping/distributed_remapping.jl
	modified:   test/Remapping/interpolate_array.jl
	modified:   src/Remapping/distributed_remapping.jl
	modified:   src/Remapping/interpolate_array.jl
	modified:   test/Remapping/distributed_remapping.jl
	modified:   test/Remapping/interpolate_array.jl
@akshaysridhar akshaysridhar marked this pull request as ready for review February 9, 2026 20:52
Copy link
Member

@ph-kev ph-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests in ClimaDiagnostics are failing because a default wasn't provided for horizontal_method in the Remapper object?

I think someone who know more about the math of interpolation should look at this too.

@akshaysridhar
Copy link
Member Author

I think the tests in ClimaDiagnostics are failing because a default wasn't provided for horizontal_method in the Remapper object?

I think someone who know more about the math of interpolation should look at this too.

Thanks @ph-kev : API has been updated to fix downstream failures - and struct properties updated in BilinearRemapping to maintain the current API (+ minor docs fixes following your suggestions)

@akshaysridhar akshaysridhar changed the title Try simpler horizontal remapping methods for diagnostics Simpler horizontal remapping methods for diagnostics Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants