Skip to content

Patch required for Oceananigans >=0.97.4#588

Merged
taimoorsohail merged 15 commits intomainfrom
ncc/patch-for-Oceananigans-0.97.4
Jul 28, 2025
Merged

Patch required for Oceananigans >=0.97.4#588
taimoorsohail merged 15 commits intomainfrom
ncc/patch-for-Oceananigans-0.97.4

Conversation

@navidcy
Copy link
Copy Markdown
Member

@navidcy navidcy commented Jul 27, 2025

After CliMA/Oceananigans.jl#4668, theOceananigans.BoundaryConditions.FieldBoundaryConditions inputs changed; one needs to give instantiated location tuple.

Also closes #589

@navidcy navidcy added the dependencies Pull requests that update a dependency file label Jul 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 27, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.25%. Comparing base (456c59c) to head (c2beeb0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/DataWrangling/metadata_field_time_series.jl 0.00% 1 Missing ⚠️
src/Diagnostics/mixed_layer_depth.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   21.08%   23.25%   +2.16%     
==========================================
  Files          48       47       -1     
  Lines        2888     2843      -45     
==========================================
+ Hits          609      661      +52     
+ Misses       2279     2182      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@navidcy navidcy requested a review from taimoorsohail July 28, 2025 02:10
@navidcy
Copy link
Copy Markdown
Member Author

navidcy commented Jul 28, 2025

I think this is ready to be merged!

@taimoorsohail taimoorsohail merged commit af11299 into main Jul 28, 2025
36 of 47 checks passed
@taimoorsohail taimoorsohail deleted the ncc/patch-for-Oceananigans-0.97.4 branch July 28, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CondaPkg fails to install copernicusmarine

2 participants