Update Bathymetry.jl

[ruoyan88]

Problem

regrid_bathymetry fails when used with RotatedLatitudeLongitudeGrid due to a strict grid type check in interpolate_bathymetry_in_passes.

Solution

Remove the unnecessary grid type validation as suggested in the discussion. The interpolate! function only depends on the source grid type, not the destination grid type.

Changes

• Replace the strict type check with string(nameof(typeof(target_grid))) to support any grid type while preserving logging functionality.

Closes #666

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.03%. Comparing base (08ccc76) to head (8ca072d).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Bathymetry.jl	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #702       +/-   ##
===========================================
+ Coverage   11.46%   32.03%   +20.56%     
===========================================
  Files          59       59               
  Lines        3261     3318       +57     
===========================================
+ Hits          374     1063      +689     
+ Misses       2887     2255      -632     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[glwagner]

We want to keep the error, and extend support to any OrthogonalSphericalShellGrid probably.

[ruoyan88]

@glwagner Thanks for the review!
So you would prefer to keep the error as-is and extend it to cover OrthogonalSphericalShellGrid (and potentially other orthogonal grids in the future)?
Should I revert my current changes and implement the stricter check instead?

[glwagner]

hmm actually I think I misunderstood the code. This is purely getting the name of the grid...

I take it back, this is ok to merge. However, I would move where we define gridtype and put it next to the string, so that it is more obvious the purpose of gridtype

[glwagner]

I suggest moving gridtype = string(nameof(typeof(target_grid))) to line 229.

[ruoyan88]

@glwagner Thanks a lot for reviewing and approving! 🚀