Skip to content

Revive codecov#5108

Merged
navidcy merged 44 commits intomainfrom
ncc/codecov
Jan 10, 2026
Merged

Revive codecov#5108
navidcy merged 44 commits intomainfrom
ncc/codecov

Conversation

@navidcy
Copy link
Copy Markdown
Member

@navidcy navidcy commented Jan 6, 2026

@navidcy navidcy added the testing 🧪 Tests get priority in case of emergency evacuation label Jan 6, 2026
@giordano
Copy link
Copy Markdown
Collaborator

giordano commented Jan 7, 2026

2026-01-07 00:51:10 INFO   Searching for artifacts: "**/*.cov"
buildkite-agent: fatal: failed to download artifacts: No artifacts found for downloading

😢

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@af2c591). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5108   +/-   ##
=======================================
  Coverage        ?   66.29%           
=======================================
  Files           ?      380           
  Lines           ?    20487           
  Branches        ?        0           
=======================================
  Hits            ?    13582           
  Misses          ?     6905           
  Partials        ?        0           
Flag Coverage Δ
buildkite 66.29% <ø> (?)
julia 66.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@navidcy
Copy link
Copy Markdown
Member Author

navidcy commented Jan 9, 2026

I'm closing this (and deleting the branch) in favour of #5128.
I accidentally pushed secret here.

@navidcy navidcy closed this Jan 9, 2026
@navidcy navidcy deleted the ncc/codecov branch January 9, 2026 23:29
@navidcy navidcy restored the ncc/codecov branch January 10, 2026 00:00
@navidcy navidcy reopened this Jan 10, 2026
@navidcy navidcy merged commit 7e4ffb6 into main Jan 10, 2026
55 of 57 checks passed
@navidcy navidcy deleted the ncc/codecov branch January 10, 2026 01:34
@navidcy
Copy link
Copy Markdown
Member Author

navidcy commented Jan 10, 2026

Screenshot 2026-01-10 at 2 01 43 pm

(This only includes the main buildkite CI suite; not the GH Actions nor the Distributed Buildkite!)

Comment thread .buildkite/pipeline.yml
Comment on lines -148 to +171
julia +$JULIA_VERSION_ENZYME -O0 --color=yes --project -e 'using Pkg; Pkg.test()'
# Run tests (but don't exit immediately so we can upload coverage even if tests fail)
set +e
julia +$JULIA_VERSION -O0 --color=yes --project --code-coverage=user -e 'using Pkg; Pkg.test(coverage="user")'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have retained JULIA_VERSION_ENZYME instead of JULIA_VERSION, and because of #5136 (comment), actual tests failures weren't spotted: #5136 (comment)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I was wondering why the extension wasn't included in the coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package 📦 Quite meta testing 🧪 Tests get priority in case of emergency evacuation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants