Increase prefetch size to 32 KB #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ring buffer used to check for ClickHouse exceptions, implemented in contrib/poco/Net/src/HTTPChunkedStream.cpp, has a size of 32 KB. In case of an abrupt connection close without properly ending the chunked encoded stream, the ring buffer searches the last 32 KB for exceptions. However, this is not very effective if the AmortizedIStreamReader prefetches only 8 KB of data. This change increases the prefetch size to 32 KB.
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ring buffer used to check for ClickHouse exceptions, implemented in
contrib/poco/Net/src/HTTPChunkedStream.cpp, has a size of 32 KB. In case of an abrupt connection close without properly ending the chunked encoded stream,HTTPChunkedStreamsearches the last 32 KB for exceptions. However, this is not very effective if theAmortizedIStreamReaderprefetches only 8 KB of data. This change increases the prefetch size to 32 KB.