Prepend chromosomes with chr to match the SAM/BAM files.#132
Open
roryk wants to merge 1 commit intoClinical-Genomics:mainfrom
Open
Prepend chromosomes with chr to match the SAM/BAM files.#132roryk wants to merge 1 commit intoClinical-Genomics:mainfrom
roryk wants to merge 1 commit intoClinical-Genomics:mainfrom
Conversation
Author
|
Sorry, I'm terrible and added a separate commit on to this cosmetic one. If you like one and not the other feel free to ignore one of them. |
Contributor
There was a problem hiding this comment.
This leading "chr" must be a mistake, right? 😃
Contributor
|
Thanks a lot @roryk - good catch! I'll be happy to test the PR locally after you've made the few suggested changes If you have time you could also update the |
apply_bed_stream takes a function and a BED stream applies the function to every interval in the BED stream Also fixes the test BED file not having chr prepended to the chromosome.
Contributor
|
Superb Rory! Very nice touch with the rebase - I should keep learning more about how to do that And I wonder what it say of me if I'm blushing a little reading you last comment? 😅 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Robin,
The demo was failing because the chromosome names didn't match up with the alignment files. This fixes that. Hope you are well.