Conversation
dnil
left a comment
dnil
left a comment
There was a problem hiding this comment.
Sorry, missed this one! Anyway, I don't think you should be doing any of the version changes manually, or normally the changelog either, but I don't really see the "unreleased" pattern in the config here. Maybe the latter needs fixing, or just simply do that one manually. Check an old bump or compare to another repo we fixed more recently if you want to be sure. I'm very ready to be corrected, but pretty sure this is going to go wrong if merged as-is. 😊 No objection to the bump as such though, so marking approved.
| This project adheres to [Semantic Versioning](http://semver.org/). | ||
|
|
||
| ## [unreleased] | ||
| ## [4.8] - 2025-12-03 |
There was a problem hiding this comment.
It's kind of a nice touch with the date! Saves going back to the tags when searching for it.
.bumpversion.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tool.bumpversion] | |||
| current_version = "4.7.2" | |||
| current_version = "4.8.0" | |||
There was a problem hiding this comment.
Eh, wait, we are using bump version here, right? Then you should not need to touch this, only note that it is supposed to be a minor in the bump message! If automation failed for some reason, this would be the way to go I guess.
There was a problem hiding this comment.
I just saw that automation failed last time and you had to do it manually. I can revert and only change changelog?
There was a problem hiding this comment.
Yes, should be fine. You could also add like
https://github.com/Clinical-Genomics/loqusdb/blob/3db9c1994317eccd0b9daf04fb6dd118f322b018/.bumpversion.cfg#L14
to the bumpversion.toml to have it do the changelog automatically as well. But up to you. The date is nice, and might need a little research to get into the bump version config. Just remember to note in the merge message it is to be a minor.
There was a problem hiding this comment.
And yes, see that now. 😊 Sorry for setting a bad example!
In my defence there was a need for new images and versions for automation that time.
There was a problem hiding this comment.
I don't think it worked?
There was a problem hiding this comment.
Whatever, I did it manually
|
Deployed today on hasta prod: 
|
2 participants
[4.8] - 2025-12-03
Added
--buildoption to the init command, to be able to automatically bootstrap a database in genome build 38Fixed
Review
Thanks for filling in who performed the code review and the test!
This version is a