Skip to content

Fix deliverable names for taxprofiler#155

Open
sofstam wants to merge 7 commits intomainfrom
fix_deliverables_taxprofiler
Open

Fix deliverable names for taxprofiler#155
sofstam wants to merge 7 commits intomainfrom
fix_deliverables_taxprofiler

Conversation

@sofstam
Copy link
Contributor

@sofstam sofstam commented Jan 19, 2026

Description

Changed

  • This PR removes the _pe suffix from the fixtures in taxprofiler
  • The multiqc files (multiqc_general_stats.json, multiqc_fastp.json) are removed because with 1.28 version, they were moved to multiqc_data.json file instead.

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy <branch-name>
hermes-test <command here>

How to test

  • login to ...
  • do ...

Expected test result

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (30521a8) to head (c876156).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          28       28           
  Lines        1012     1012           
=======================================
  Hits          939      939           
  Misses         73       73           
Flag Coverage Δ
unittests 92.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sofstam
Copy link
Contributor Author

sofstam commented Jan 20, 2026

Screenshot 2026-01-20 at 15 22 05

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just, there's no description in the PR why the MultiQC files are removed.

@sofstam
Copy link
Contributor Author

sofstam commented Jan 21, 2026

Just, there's no description in the PR why the MultiQC files are removed.

Updated the description, hope it is clear now.

Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. They also exist in cg in cg/resources/taxprofiler_bundle_filenames.yaml if you wanted to remove them completely.

@sofstam
Copy link
Contributor Author

sofstam commented Jan 21, 2026

Looks good to me. They also exist in cg in cg/resources/taxprofiler_bundle_filenames.yaml if you wanted to remove them completely.

I removed the corresponding multiqc files from cg/resources/taxprofiler_bundle_filenames.yaml. Clinical-Genomics/cg#4839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants