Skip to content

Feat(Nallo) Add Sambamba bed files#156

Open
peterpru wants to merge 4 commits intomainfrom
nallo-chanjo1
Open

Feat(Nallo) Add Sambamba bed files#156
peterpru wants to merge 4 commits intomainfrom
nallo-chanjo1

Conversation

@peterpru
Copy link
Member

@peterpru peterpru commented Jan 20, 2026

Description

This PR adds the sambamba files to the deliverables. In preparation for using chanjo38 with Nallo.

Note to reviewer: to be tested in conjunction with the corresponding cg PR.

Added

  • sambamba_depth files for Nallo

Changed

  • d4 files optional for Nallo

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy nallo-chanjo1
hermes-test cg workflow nallo store-housekeeper distinctgannet

How to test

  • login to hasta
  • do us, pull the corresponding cg branch
  • do hermes test deploy
  • do cg workflow nallo store CASE

Expected test result

  • check that the command completes without error
  • check that the sambamba file is in the hk bundle
  • Take a screenshot and attach or copy/paste the output.
image

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@peterpru peterpru self-assigned this Jan 20, 2026
@peterpru peterpru requested a review from a team as a code owner January 20, 2026 07:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.81%. Comparing base (7892e36) to head (4d35cf5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          28       28           
  Lines        1016     1016           
=======================================
  Hits          943      943           
  Misses         73       73           
Flag Coverage Δ
unittests 92.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants