Conversation
…ns-reports (patch) ### Added - List of verified organism to typing report
…sing (patch) ### Changed - Alter species parsing from url
Contributor
Author
Contributor
Author
sofstam
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This pull request updates the
microSALTapplication with a minor version bump and several code and template improvements. The main changes focus on improving error handling, refactoring species name parsing for better reliability, updating template content for clarity, and cleaning up import statements.Template and Documentation Improvements:
typing_page.htmlwas restructured for improved readability and now dynamically lists verified organisms using theverified_organismsvariable.Code Refactoring and Reliability:
referencer.pywas refactored to handle edge cases (e.g., species with extra names or suffixes) more robustly, improving organism matching and reference retrieval. [1] [2]referencer.pywas updated to avoid referencing unused exception variables, simplifying the code and logging only relevant messages. [1] [2] [3]Code Quality and Consistency:
referencer.pywere reordered and cleaned up for clarity and consistency.not ininstead ofnot ... inand updating string comparison logic for clarity. [1] [2]Version Update:
4.2.5to4.2.7in__init__.py.Primary function of PR
Testing
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAMEusconda activate S_microSALTmicroSALT analyse --input /path/to/fastq/ SAMPLEINFO_FILETest results
These are the results of the tests, and necessary conclusions, that prove the stability of the PR.
Sign-offs