Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the fetch_external method where the lower string method was called without parentheses, causing it to reference the method object instead of executing the method to convert the species name to lowercase.
Key Changes
- Added missing parentheses to
.lower()method call on line 271 ofmicroSALT/utils/referencer.py
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes a small fix to the
fetch_externalmethod inmicroSALT/utils/referencer.py. The change corrects a bug where thelowermethod was missing parentheses, ensuring that species names are properly converted to lowercase before splitting.Primary function of PR
Testing
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAMEusconda activate S_microSALTmicroSALT analyse --input /path/to/fastq/ SAMPLEINFO_FILETest results
These are the results of the tests, and necessary conclusions, that prove the stability of the PR.
Sign-offs