Skip to content

hotfix(function split)#220

Merged
karlnyr merged 1 commit intorc4.2.7bfrom
fix-function-split
Nov 13, 2025
Merged

hotfix(function split)#220
karlnyr merged 1 commit intorc4.2.7bfrom
fix-function-split

Conversation

@karlnyr
Copy link
Contributor

@karlnyr karlnyr commented Nov 13, 2025

Description

This pull request makes a small fix to the fetch_external method in microSALT/utils/referencer.py. The change corrects a bug where the lower method was missing parentheses, ensuring that species names are properly converted to lowercase before splitting.

Primary function of PR

  • Hot-fix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • microSALT analyse --input /path/to/fastq/ SAMPLEINFO_FILE

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

  • Approved to run at Clinical-Genomics by @karlnyr or @Clinical-Genomics/micro

@karlnyr karlnyr requested a review from a team as a code owner November 13, 2025 15:35
@karlnyr karlnyr requested review from Copilot and removed request for a team November 13, 2025 15:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the fetch_external method where the lower string method was called without parentheses, causing it to reference the method object instead of executing the method to convert the species name to lowercase.

Key Changes

  • Added missing parentheses to .lower() method call on line 271 of microSALT/utils/referencer.py

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@karlnyr karlnyr merged commit e1530cc into rc4.2.7b Nov 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant