Add flexibility to the parsing of custom archived loqusDB instances#5622
Add flexibility to the parsing of custom archived loqusDB instances#5622northwestwitch wants to merge 177 commits intomainfrom
Conversation
scout/server/config.py
Outdated
| "clinical_genomics_loqusObs": {"field": "local_obs_old", "type": int}, | ||
| "clinical_genomics_loqusFrq": {"field": "local_obs_old_freq", "type": float}, | ||
| "clin_obs": {"field": "local_obs_old", "type": int}, | ||
| # prefixes → auto-expand into *_Obs, *_Hom, *_Frq |
There was a problem hiding this comment.
Is this too complex to have in the config file? Would it be better with a long list of single keys instead?
There was a problem hiding this comment.
Hm, yes, it is rather complex isn't it? I like the idea though. Perhaps we could leave the old ones in running code, or as a similar structure from constants, and allow adding only the systematic prefix ones from config?
There was a problem hiding this comment.
I like the idea of removing hard coded keys as much as possible. Perhaps we could try to just have a list (no matter how long) of keys (containing prefixes and suffixes). That would be very clear
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5622 +/- ##
==========================================
- Coverage 83.88% 83.88% -0.01%
==========================================
Files 336 336
Lines 21022 21020 -2
==========================================
- Hits 17635 17633 -2
Misses 3387 3387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I want to revise this PR and make sure I access the config values after the config file has been parsed, otherwise I might be skipping the situation where the config is the yaml file used for instance by our cli. Still i progress! |
|



This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stageand the server iscg-vm1.ssh <USER.NAME>@cg-vm1.scilifelab.sesudo -iu hiseq.clinicalssh localhostpodman pssystemctl --user stop scout@<name_of_currently_deployed_branch>systemctl --user start scout@<this_branch>systemctl --user status scout.targetscout-stage) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.seus; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browserbash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>us; scout --versionpaxaprocedure, which will release the allocated resource (scout-stage) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: