Refactor SNV germline ClinVar submissions#5994
Open
northwestwitch wants to merge 68 commits intomainfrom
Open
Conversation
Co-authored-by: Chiara Rasi <rasi.chiara@gmacil.com>
a6ee603 to
96e9370
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5994 +/- ##
==========================================
- Coverage 83.88% 83.62% -0.27%
==========================================
Files 336 336
Lines 21022 20900 -122
==========================================
- Hits 17635 17478 -157
- Misses 3387 3422 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
northwestwitch
commented
Jan 30, 2026
| - Refactored ClinVar germline submissions to be compliant to the changes introduced by the ClinVar API: `clinvarSubmission` -> `germlineSubmission` (#5994) | ||
| - Old ClinVar germline submissions become automatically deprecated. They can be viewed but not submitted to ClinVar (#5994) | ||
| - Temporarily removed button `Delete submission from ClinVar` (based on the deprecated preClinVar software) to be replaced with a direct request to the ClinVar API instead (#5994) | ||
| - Temporarily deactivated the submission of SVs to ClinVar using the API (#5994) |
Member
Author
There was a problem hiding this comment.
I reasoned that this PR contains enough changes already. This can be fixed shortly after
Member
Author
|
This works more or less as intended now, so I'm marking it ready for review. I'm aware of its size so I don't expect any quick review on this. I'll just leave it for when we have time |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stageand the server iscg-vm1.ssh <USER.NAME>@cg-vm1.scilifelab.sesudo -iu hiseq.clinicalssh localhostpodman pssystemctl --user stop scout@<name_of_currently_deployed_branch>systemctl --user start scout@<this_branch>systemctl --user status scout.targetscout-stage) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.seus; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browserbash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>us; scout --versionpaxaprocedure, which will release the allocated resource (scout-stage) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: