FEAT: Add switch presets #428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Team/algnet into presets_for_switch
PaulRalnikov
requested changes
Sep 11, 2025
| }; | ||
|
|
||
| class ECMPHasher : public IPacketHasher { | ||
| class ECMPHasher : public ClonebleHasher<ECMPHasher> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| class ECMPHasher : public ClonebleHasher<ECMPHasher> { | |
| class ECMPHasher : public ClonebleHasher<ECMPHasher> { |
| }; | ||
|
|
||
| class SaltECMPHasher : public IPacketHasher { | ||
| class SaltECMPHasher : public ClonebleHasher<SaltECMPHasher> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| class SaltECMPHasher : public ClonebleHasher<SaltECMPHasher> { | |
| class SaltECMPHasher : public ClonebleHasher<SaltECMPHasher> { |
| }; | ||
|
|
||
| class FLowletHasher : public IPacketHasher { | ||
| class FLowletHasher : public ClonebleHasher<FLowletHasher> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| class FLowletHasher : public ClonebleHasher<FLowletHasher> { | |
| class FLowletHasher : public ClonebleHasher<FLowletHasher> { |
| }; | ||
|
|
||
| class SymmetricHasher : public IPacketHasher { | ||
| class SymmetricHasher : public ClonebleHasher<SymmetricHasher> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| class SymmetricHasher : public ClonebleHasher<SymmetricHasher> { | |
| class SymmetricHasher : public ClonebleHasher<SymmetricHasher> { |
| }; | ||
|
|
||
| class RandomHasher : public IPacketHasher { | ||
| template <typename Hasher> |
Collaborator
There was a problem hiding this comment.
Sorry, but I think, naming I suggested before is not really good
Suggested change
| template <typename Hasher> | |
| template <typename THasher> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.