FEAT: Single CC MPLB #500
Draft
FEAT: Single CC MPLB #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArtyomPeshkov
left a comment
ArtyomPeshkov
left a comment
There was a problem hiding this comment.
Move AckInfo to utils and add on_ack overload
Think about MPLB packet distribution (delays management)
PaulRalnikov
force-pushed
the
single-cc-mplb
branch
from
d0fe102 to
b9a6f09
Compare
Az3git
reviewed
Jan 23, 2026
| flow_weak.lock()->send( | ||
| std::vector<PacketInfo>(1, std::move(packet_info))); | ||
| }); | ||
| m_packets_in_flight++; |
Contributor
There was a problem hiding this comment.
m_packets_in_flight increases but does not decrease anywhere
| return; | ||
| } | ||
| auto mplb = mplb_weak.lock(); | ||
| mplb->m_cc->on_ack(info.rtt, info.avg_rtt, info.ecn_flag); |
Contributor
There was a problem hiding this comment.
Suggested change
| mplb->m_cc->on_ack(info.rtt, info.avg_rtt, info.ecn_flag); | |
| mplb->m_cc->on_ack(info.rtt, info.avg_rtt, info.ecn_flag); | |
| mplb->m_packets_in_flight--; |
| TimeNs pacing_delay = m_cc->get_pacing_delay(); | ||
| TimeNs shift(0); | ||
|
|
||
| std::size_t packets_count = std::ceil(data.size / m_packet_size); |
Contributor
There was a problem hiding this comment.
Suggested change
| std::size_t packets_count = std::ceil(data.size / m_packet_size); | |
| auto packets_count = (data.size + m_packet_size - SizeByte(1)) / m_packet_size; |
It's a safe option, but if everything is fine, leave it as is.
| std::weak_ptr<SingleCCMplb> mplb_weak = shared_from_this(); | ||
| PacketCallback packet_callback = [observer, mplb_weak, | ||
| flow_weak](PacketAckInfo info) { | ||
| observer->on_single_callback(); |
Contributor
There was a problem hiding this comment.
If the CallbackObserver calls the final callback() on the last packet, the custom callback may be triggered before the CC/delivered/inflight update of the last packet. This can break tests/logic if the user immediately looks at get_context() in the callback.
Please check it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #496