feat: add custom names to planex group favorites#123
Merged
Conversation
|
maybe un rebase car 5 ou 6 commits c'est long pour l'historique (je suis pas censé relire mais la MR m'a intrigué) |
Collaborator
Author
oui, j'y reviendrai demain j'ai oublié de lint aussi (et ignyx regardera) |
ignyx
changed the title
Contributor
|
Merci pour la PR ! 5-6 commits ne me choquent pas, on n'a pas de politique de squash avant de merge. Ne te sens pas obligé de réduire le nombre de commits 👍 Pour lint: |
ignyx
requested changes
Jul 23, 2025
Contributor
ignyx
left a comment
ignyx
left a comment
There was a problem hiding this comment.
Looks good dans l'ensemble ! Chapeau d'avoir fait les 4 traductions !
J'ai rajouté quelques commentaires juste en relisant le code 👍
Function definition guarantees it will be an error
isValid schema should return a boolean
ignyx
approved these changes
Aug 11, 2025
Contributor
ignyx
left a comment
ignyx
left a comment
There was a problem hiding this comment.
LGTM ! Can't wait to see this action !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the feature of editing favorite groups name.
More details in the steps detailed on the #19 Issue.
Resolves #19