Skip to content

chore(proximo): remove proximo service#131

Open
pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
pierrbt:remove-proximo
Open

chore(proximo): remove proximo service#131
pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
pierrbt:remove-proximo

Conversation

@pierrbt
Copy link

@pierrbt pierrbt commented Nov 6, 2025

Proximo API has been discontinued. I removed all proximo references because they were now useless.
This PR resolves #87
Feel free to comment any error I made.

I created a small script to reset the pinned items on the dashboard if it contained proximo, because else it would display a white square instead of another logo.

Here it is (in fact one of the only thing added) :

export function retrievePreferences<
  Keys extends PreferenceKeys,
  T extends Partial<PreferencesType>
>(keys: Array<Keys>, defaults: T): Promise<T> {
  return new Promise((resolve: (preferences: T) => void) => {
    AsyncStorage.multiGet(keys)
      .then((result) => {
        const preferences = { ...defaults };
        result.forEach((item) => {
          let [key, value] = item;
          if (value !== null) {
///// THIS PART IS ADDED
            if (key === "dashboardItems" && value.includes("proximo")) {
              // The user has changed the dashboard items
              // We need to replace Proximo because it isn't supported anymore (05/11/2025)
              // In order to do so, we reset the dashboard items to the default value
              value = defaultPreferences.dashboardItems;
              setPreference(PreferenceKeys.dashboardItems, value, defaults);
              console.log("Proximo successfully removed");
            }

///// END

            preferences[key as Keys] = value;
          }
        });
        resolve(preferences);
      })
      .catch(() => resolve(defaults));
  });
}

As you can see, the Proximo is no longer available.

image image

@pierrbt
Copy link
Author

pierrbt commented Nov 14, 2025

@ignyx Keep me up when you have time to review this

Copy link
Contributor

@ignyx ignyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ! Thanks for looking into it.

I made a few minor change requests, and then we should be good to go 🎉

Additionally, npm run lint must pass. Run npm run lint-fix

pierrbt and others added 5 commits November 20, 2025 16:11
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
@pierrbt
Copy link
Author

pierrbt commented Nov 20, 2025

@ignyx I need your help. I'm running the app on Windows, and all the errors are caused prettier, saying that CRLF are incorrect. However the .gitattributes files shows that they are supposed to be CRLF. How can I do to pass the tests ?

When I'm running lint-fix, it changes all my files to LF, which makes git want to commit 100+ files

@pierrbt
Copy link
Author

pierrbt commented Nov 20, 2025

I've changed the settings of prettier. Tell me if it's incorrect. Else I think everything looks ok.

@pierrbt pierrbt changed the title Remove Proximo chore(proximo): remove proximo service Nov 20, 2025
@pierrbt
Copy link
Author

pierrbt commented Dec 8, 2025

Any news about this ?

@ignyx
Copy link
Contributor

ignyx commented Dec 9, 2025

Sorry, been busy, I've noted to look into it this weekend 👍 Thanks for the changes !

@pierrbt
Copy link
Author

pierrbt commented Dec 9, 2025

I perfectly understand, take your time if you have other things planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Proximo

2 participants