chore(proximo): remove proximo service#131
Open
pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
Open
chore(proximo): remove proximo service#131pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
pierrbt wants to merge 17 commits intoClubInfoInsaT:masterfrom
Conversation
I have removed the numver of articles available at proximo. It is still sent by the API but unused in the app
Author
|
@ignyx Keep me up when you have time to review this |
ignyx
requested changes
Nov 16, 2025
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Co-authored-by: ignyx <paul@shimaore.net>
Author
|
@ignyx I need your help. I'm running the app on Windows, and all the errors are caused prettier, saying that CRLF are incorrect. However the .gitattributes files shows that they are supposed to be CRLF. How can I do to pass the tests ? When I'm running lint-fix, it changes all my files to LF, which makes git want to commit 100+ files |
Author
|
I've changed the settings of prettier. Tell me if it's incorrect. Else I think everything looks ok. |
Author
|
Any news about this ? |
Contributor
|
Sorry, been busy, I've noted to look into it this weekend 👍 Thanks for the changes ! |
Author
|
I perfectly understand, take your time if you have other things planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proximo API has been discontinued. I removed all proximo references because they were now useless.
This PR resolves #87
Feel free to comment any error I made.
I created a small script to reset the pinned items on the dashboard if it contained proximo, because else it would display a white square instead of another logo.
Here it is (in fact one of the only thing added) :
As you can see, the Proximo is no longer available.