feat(map): add map of the campus#133
Open
pierrbt wants to merge 2 commits intoClubInfoInsaT:masterfrom
Open
Conversation
I added a map in the student services. The map is made by ClubInfoInsaT. Co-Authored-By: Baptiste <baptiste.rebillard@outlook.fr>
Author
|
Where could we make the map website available ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add the map of the campus in the application.
It replaces PR #65
And it closes #63
When we click on the map, the webview uses https://github.com/ClubInfoInsaT/Map-INSA to show the campus
Only little concern, the website uses a bit of CPU, but this can surely be optimised directly in the website itself, depends if it is still maintained.
I've ran lint-fix successfully.
Fell free to ask any question
The reviewer needs to :
Thanks to :
@baptistereb for the first implementation
@gerald-lbn for the first PR