Skip to content

Dev: ui_sbd: Display and warn on sbd configuration file modification time during sbd.service status #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Dev: ui_sbd: Display and warn on sbd configuration file modification time during sbd.service status #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions crmsh/ui_sbd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import typing
import re
import os
import time

from crmsh import sbd
from crmsh import watchdog
Expand Down Expand Up @@ -121,6 +122,7 @@ def __init__(self):
self.service_manager: ServiceManager = None
self.cluster_shell: sh.cluster_shell = None
self.cluster_nodes: list[str] = None
self.sysconfig_modified_time: float = None

command.UI.__init__(self)

Expand Down Expand Up @@ -587,17 +589,21 @@ def do_purge(self, context, *args) -> bool:
def _print_sbd_type(self):
if not self.service_manager.service_is_active(constants.SBD_SERVICE):
return
self.sysconfig_modified_time = os.path.getmtime(sbd.SBDManager.SYSCONFIG_SBD)
formatted_time = time.strftime('%a %Y-%m-%d %H:%M:%S CST', time.localtime(self.sysconfig_modified_time))
modified_time_str = f"{sbd.SBDManager.SYSCONFIG_SBD} modified at {formatted_time}"
print("# Type of SBD:")
if self.device_list_from_config:
print("Disk-based SBD configured")
print(f"Disk-based SBD configured, {modified_time_str}")
else:
print("Diskless SBD configured")
print(f"Diskless SBD configured, {modified_time_str}")
print()

def _print_sbd_status(self):
padding = 2
status_len = 8
max_node_len = max(len(node) for node in self.cluster_nodes) + padding
warn_str = ""

print(f"# Status of {constants.SBD_SERVICE}:")
print(f"{'Node':<{max_node_len}}|{'Active':<{status_len}}|{'Enabled':<{status_len}}|Since")
Expand All @@ -609,10 +615,21 @@ def _print_sbd_status(self):
systemd_property = "ActiveEnterTimestamp" if is_active else "ActiveExitTimestamp"
since_str_prefix = "active since" if is_active else "disactive since"
systemctl_show_cmd = f"systemctl show {constants.SBD_SERVICE} --property={systemd_property} --value"
since = self.cluster_shell.get_stdout_or_raise_error(systemctl_show_cmd, node) or "N/A"
since = self.cluster_shell.get_stdout_or_raise_error(systemctl_show_cmd, node)
if since:
if node == utils.this_node():
since_timestamp = utils.parse_to_timestamp(since)
if since_timestamp and since_timestamp < self.sysconfig_modified_time:
warn_str = f"{sbd.SBDManager.SYSCONFIG_SBD} was modified while sbd is active. Restart cluster service is highly recommended."
else:
since = "N/A"
print(f"{node:<{max_node_len}}|{is_active_str:<{status_len}}|{is_enabled_str:<{status_len}}|{since_str_prefix}: {since}")
print()

if warn_str:
logger.warning(warn_str)
print()

def _print_watchdog_info(self):
padding = 2
max_node_len = max(len(node) for node in self.cluster_nodes) + padding
Expand Down
Loading