Skip to content

[crmsh-5.0] Dev: sbd: Improve the process of leveraging maintenance mode #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: crmsh-5.0
Choose a base branch
from
Draft

[crmsh-5.0] Dev: sbd: Improve the process of leveraging maintenance mode #1951

wants to merge 3 commits into from

Conversation

@liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Oct 23, 2025

Backport from #1950

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 37.50000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.89%. Comparing base (f6e3881) to head (d827057).

Files with missing lines Patch % Lines
crmsh/ui_sbd.py 48.00% 13 Missing ⚠️
crmsh/utils.py 18.75% 13 Missing ⚠️
crmsh/sbd.py 50.00% 2 Missing ⚠️
crmsh/xmlutil.py 33.33% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 55.36% <4.16%> (-0.04%) ⬇️
unit 52.87% <37.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/sbd.py 85.60% <50.00%> (-0.31%) ⬇️
crmsh/xmlutil.py 70.28% <33.33%> (-0.12%) ⬇️
crmsh/ui_sbd.py 83.16% <48.00%> (-0.65%) ⬇️
crmsh/utils.py 67.53% <18.75%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 force-pushed the 20251022_improve_leverage_maintenance_mode_crmsh50 branch from c7c42b1 to 6258cfc Compare October 23, 2025 14:56
@liangxin1300 liangxin1300 marked this pull request as ready for review October 31, 2025 05:28
@liangxin1300
Dev: sbd: Improve the process of leveraging maintenance mode
a02f547 
- Drop the function `restart_cluster_if_possible`
- Introduced a new function `utils.able_to_restart_cluster` to check if
  the cluster can be restarted. Call it before changing any configurations.
- Add leverage maintenance mode in `sbd device remove` and `sbd purge` commands
@liangxin1300
Dev: unittests: Adjust unit test for previous commit
e753ef7
@liangxin1300 liangxin1300 force-pushed the 20251022_improve_leverage_maintenance_mode_crmsh50 branch from 6258cfc to e753ef7 Compare November 11, 2025 11:30
@liangxin1300
Dev: ui_sbd: Validate purge option first
d827057 
And give error if the option is not crashdump
@liangxin1300 liangxin1300 marked this pull request as draft November 14, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasyang2022 nicholasyang2022 Awaiting requested review from nicholasyang2022

@zzhou1 zzhou1 Awaiting requested review from zzhou1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@liangxin1300