Refactor: libcrmcommon: Drop pcmk__time_hr_t #3988
Merged
+89
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only callers were a fuzzer line (which was only there to test this function) and a unit test of a different function. We can just do the assignment inside the unit test. This leaves a little bit of duplication with time_to_hr(), but the goal is to replace most of our iso8601 library with something external (see upstream task T432). So I'm not concerned about duplication in one place. This does requires exposing struct crm_time_s internally, so that we can reference its members in the unit test. Alternatively we could create getter functions for the members, but this is easier. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
This aims to address a false positive issue found by a fuzzer. See: ClusterLabs#3985 https://issues.oss-fuzz.com/issues/456526118 (likely will get "Access Denied") Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
And implement a few other best practices, like bool instead of gboolean, limiting scope, and using const. Replace three temporary string variables (timestamp, timestamp_epoch, and timestamp_usec) with one (str). Use the fact that the now variable is guaranteed non-NULL by the time we reach the place where we set the three timestamp params, to remove some nesting. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
A pcmk__time_hr_t object is just a crm_time_t with an int appended for useconds. Instead of taking that object, having to construct it, etc., just take the crm_time_t and int. This removes the sole use of pcmk__time_hr_t, so that we can drop it. This makes sense to do, given that our goal is to replace most of our time library with something external (see T432). Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
It has no remaining callers. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Nothing uses it anymore. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
It's basically redundant. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
clumens
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also aims to fix the fuzzer issue noted in #3985.