Skip to content
This repository was archived by the owner on Nov 14, 2017. It is now read-only.

Conversation

@Legoless
Copy link

Added NSError convenience category, to pull information from NSError instances sent by ReactiveCocoa when requests fail. This is to remove boilerplate code you get when trying to handle specific NSError instance in case of networking failure.

@CodaFi
Copy link
Owner

CodaFi commented Mar 30, 2015

So wait, is this a file from AFNetworking or did you write this yourself?

@Legoless
Copy link
Author

This is a file I wrote myself when using your library. I submitted it to AFNetworking main repo, but according to owner they do not want to pollute the global namespace with category methods. Usually this is not needed much with main AFNetworking blocks as you get operation which contains these objects on the fly. In this case we only get NSError when subscribed and it is annoying to pull out information from it (some boilerplate code). This category removes that.

@CodaFi
Copy link
Owner

CodaFi commented Mar 30, 2015

Then I have to request some things of you:

  • Change the license to MIT. I can't merge anything with the AFN license, it's a hassle.
  • Re-namespace everything. I use raf to avoid AFNetworking's stuff
  • Adhere to the code style of the rest of the files.

I'll leave more specific notes in line comments.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointer stars need consistency.

@Legoless
Copy link
Author

Okay, I'll update this. Just wondering did you mean "raf" or "rac"? Cause it seems it should be prefixed with rac, not raf.

@CodaFi
Copy link
Owner

CodaFi commented Mar 30, 2015

Hm... Yeah, I meant rac.

@Legoless
Copy link
Author

Updated, check if all good. :) Thanks.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to republish this here. LICENSE.md takes care of that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, LICENSE file is basically from you in this case. What should I do then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants