-
Notifications
You must be signed in to change notification settings - Fork 130
Added NSError category for Reactive programming #43
base: master
Are you sure you want to change the base?
Conversation
|
So wait, is this a file from AFNetworking or did you write this yourself? |
|
This is a file I wrote myself when using your library. I submitted it to AFNetworking main repo, but according to owner they do not want to pollute the global namespace with category methods. Usually this is not needed much with main AFNetworking blocks as you get operation which contains these objects on the fly. In this case we only get NSError when subscribed and it is annoying to pull out information from it (some boilerplate code). This category removes that. |
|
Then I have to request some things of you:
I'll leave more specific notes in line comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointer stars need consistency.
|
Okay, I'll update this. Just wondering did you mean "raf" or "rac"? Cause it seems it should be prefixed with rac, not raf. |
|
Hm... Yeah, I meant rac. |
|
Updated, check if all good. :) Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to republish this here. LICENSE.md takes care of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LICENSE file is basically from you in this case. What should I do then?
Added NSError convenience category, to pull information from NSError instances sent by ReactiveCocoa when requests fail. This is to remove boilerplate code you get when trying to handle specific NSError instance in case of networking failure.