197 dev delete grant connected to backend #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…197-dev---delete-grant-connected-to-backend
…197-dev---delete-grant-connected-to-backend
josieek
force-pushed
the
197-dev---delete-grant-connected-to-backend
branch
from
1a7d41a to
92f9145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #197
📝 Description
The fetchGrants method from /filter-bar/processGrantData is called after deleting a grant, editing an existing grant, and creating a new grant.
A useEffect in GrantItem is triggered everytime the grant modal is closed and a new grant has been submitted/edited. This function fetches the grant from backend so all new changes are immediately reflected.
I also changed some formatting bugs of NewGrantModal (such as a bug where new input fields were created everytime upload documents was pressed) and GrantItem (such as when some fields of the grant are undefined)
✔️ Verification
edit.and.delete.auto.refresh.webm
🏕️ (Optional) Future Work / Notes
fetGrants method is in filter-bar/processGrantData, but now it is called after deleting a grant, editing an existing grant, and creating a new grant. So it may make sense to move this file to another shared backend folder.