Skip to content

Conversation

@denniwang
Copy link
Contributor

@denniwang denniwang commented Sep 26, 2025

ℹ️ Issue

Closes #5

📝 Description

  • Added AWS module in terraform + RDS instance that uses infisical secrets
  • Had Nour add the secrets in infisical

✔️ Verification

Terraform plan passed

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

denniwang and others added 20 commits September 26, 2025 15:05
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
@denniwang denniwang changed the title round 3 baby Allocating RDS Instance in Terraform Sep 29, 2025
@denniwang denniwang marked this pull request as ready for review September 30, 2025 13:40
Copy link
Collaborator

@nourshoreibah nourshoreibah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, awesome work!! Just a couple of formatting suggestions. Next all hands we'll go over how to make the IDE manage white space automatically

@nourshoreibah
Copy link
Collaborator

nourshoreibah commented Sep 30, 2025

Also, could you add the issue number in PR Title so it links? Ex for issue number -1 (using fake example so it doesnt link), you would do #-1 - {PR Title}

nourshoreibah added a commit that referenced this pull request Sep 30, 2025
@denniwang denniwang changed the title Allocating RDS Instance in Terraform #5 Allocating RDS Instance in Terraform Oct 1, 2025
nourshoreibah
nourshoreibah previously approved these changes Oct 1, 2025
@denniwang denniwang requested a review from Yurika-Kan October 2, 2025 22:55
Yurika-Kan
Yurika-Kan previously approved these changes Oct 7, 2025
Copy link
Contributor

@Yurika-Kan Yurika-Kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good! clean & secure

@denniwang denniwang dismissed stale reviews from Yurika-Kan and nourshoreibah via 1fc1cf5 October 8, 2025 15:49
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
nourshoreibah
nourshoreibah previously approved these changes Oct 8, 2025
Co-authored-by: Nour Shoreibah <168875317+nourshoreibah@users.noreply.github.com>
  - Auto-formatted .tf files with terraform fmt
  - Updated README.md with terraform-docs

  Co-authored-by: denniwang <denniwang@users.noreply.github.com>
Copy link
Collaborator

@nourshoreibah nourshoreibah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Everything looks good now!!

Copy link
Contributor

@Yurika-Kan Yurika-Kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! cleaned up well~

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Terraform Plan 📖 infrastructure/github

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Show Plan
data.infisical_secrets.aws_folder: Reading...
data.infisical_secrets.github_folder: Reading...
data.infisical_secrets.infisical_folder: Reading...
data.infisical_secrets.github_folder: Read complete after 1s
data.infisical_secrets.aws_folder: Read complete after 1s
data.infisical_secrets.infisical_folder: Read complete after 1s
github_repository.branch: Refreshing state... [id=branch]
github_actions_secret.aws_secret_access_key: Refreshing state... [id=branch:AWS_SECRET_ACCESS_KEY]
github_branch_default.main: Refreshing state... [id=branch]
github_actions_secret.aws_access_key_id: Refreshing state... [id=branch:AWS_ACCESS_KEY_ID]
github_actions_secret.infisical_client_id: Refreshing state... [id=branch:INFISICAL_CLIENT_ID]
github_actions_secret.infisical_client_secret: Refreshing state... [id=branch:INFISICAL_CLIENT_SECRET]
github_branch_protection.main: Refreshing state... [id=BPR_kwDOPjZxzc4D-9hQ]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Pushed by: @nourshoreibah, Action: pull_request

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Terraform Plan 📖 infrastructure/aws

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Show Plan
data.infisical_secrets.rds_folder: Reading...
data.infisical_secrets.rds_folder: Read complete after 0s

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_db_instance.branch_rds will be created
  + resource "aws_db_instance" "branch_rds" {
      + address                               = (known after apply)
      + allocated_storage                     = 10
      + apply_immediately                     = false
      + arn                                   = (known after apply)
      + auto_minor_version_upgrade            = true
      + availability_zone                     = (known after apply)
      + backup_retention_period               = (known after apply)
      + backup_target                         = (known after apply)
      + backup_window                         = (known after apply)
      + ca_cert_identifier                    = (known after apply)
      + character_set_name                    = (known after apply)
      + copy_tags_to_snapshot                 = false
      + database_insights_mode                = (known after apply)
      + db_name                               = "branch_rds"
      + db_subnet_group_name                  = (known after apply)
      + dedicated_log_volume                  = false
      + delete_automated_backups              = true
      + domain_fqdn                           = (known after apply)
      + endpoint                              = (known after apply)
      + engine                                = "postgres"
      + engine_lifecycle_support              = (known after apply)
      + engine_version                        = "18.0"
      + engine_version_actual                 = (known after apply)
      + hosted_zone_id                        = (known after apply)
      + id                                    = (known after apply)
      + identifier                            = (known after apply)
      + identifier_prefix                     = (known after apply)
      + instance_class                        = "db.t3.micro"
      + iops                                  = (known after apply)
      + kms_key_id                            = (known after apply)
      + latest_restorable_time                = (known after apply)
      + license_model                         = (known after apply)
      + listener_endpoint                     = (known after apply)
      + maintenance_window                    = (known after apply)
      + master_user_secret                    = (known after apply)
      + master_user_secret_kms_key_id         = (known after apply)
      + monitoring_interval                   = 0
      + monitoring_role_arn                   = (known after apply)
      + multi_az                              = (known after apply)
      + nchar_character_set_name              = (known after apply)
      + network_type                          = (known after apply)
      + option_group_name                     = (known after apply)
      + parameter_group_name                  = "default.postgres18.0"
      + password                              = (sensitive value)
      + password_wo                           = (write-only attribute)
      + performance_insights_enabled          = false
      + performance_insights_kms_key_id       = (known after apply)
      + performance_insights_retention_period = (known after apply)
      + port                                  = (known after apply)
      + publicly_accessible                   = false
      + region                                = "us-east-2"
      + replica_mode                          = (known after apply)
      + replicas                              = (known after apply)
      + resource_id                           = (known after apply)
      + skip_final_snapshot                   = true
      + snapshot_identifier                   = (known after apply)
      + status                                = (known after apply)
      + storage_throughput                    = (known after apply)
      + storage_type                          = (known after apply)
      + tags_all                              = (known after apply)
      + timezone                              = (known after apply)
      + username                              = (sensitive value)
      + vpc_security_group_ids                = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan"

Pushed by: @nourshoreibah, Action: pull_request

@denniwang denniwang merged commit 11ca8e6 into main Oct 9, 2025
5 checks passed
@denniwang denniwang deleted the dw/feature/aws-rds branch October 9, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Terraform to provision an RDS Instance

4 participants