-
Notifications
You must be signed in to change notification settings - Fork 0
#5 Allocating RDS Instance in Terraform #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
…ity/branch into dw/feature/aws-rds
nourshoreibah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, awesome work!! Just a couple of formatting suggestions. Next all hands we'll go over how to make the IDE manage white space automatically
|
Also, could you add the issue number in PR Title so it links? Ex for issue number -1 (using fake example so it doesnt link), you would do |
Yurika-Kan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good! clean & secure
1fc1cf5
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
Co-authored-by: Nour Shoreibah <168875317+nourshoreibah@users.noreply.github.com>
- Auto-formatted .tf files with terraform fmt - Updated README.md with terraform-docs Co-authored-by: denniwang <denniwang@users.noreply.github.com>
nourshoreibah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Everything looks good now!!
Yurika-Kan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! cleaned up well~
Terraform Plan 📖
|
Terraform Plan 📖
|
ℹ️ Issue
Closes #5
📝 Description
✔️ Verification
Terraform plan passed
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!