Skip to content

fix spacing issues between nav bar and page content #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxn990 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix spacing issues between nav bar and page content #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db9869e
fix spacing between page content and nav
maxn990 Sep 8, 2025
e08d43c
Update main-section.tsx
maxn990 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/jumpstart-page/main-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const JumpstartIntro = ({
}: JumpstartIntroProps) => {
return (
<div className="flex flex-row items-center overflow-x-hidden">
<div className="flex flex-col h-[100vh] md:h-[90vh] justify-center md:mr-10 md:w-2/3 relative">
<div className="flex flex-col justify-center md:mr-10 md:w-2/3 relative py-10 md:py-20">
<p className="text-2xl md:text-4xl text-[#333333] md:mb-3 font-medium">
Copy link
Member

@amywng amywng Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the title match the other pages so text-2xl md:text-5xl

Jumpstart
</p>
Expand All @@ -31,7 +31,7 @@ const JumpstartIntro = ({
</a>
</div>

<div className="hidden md:flex md:w-1/3 justify-center items-center h-[100vh]">
<div className="flex md:w-1/3 justify-center items-center">
<img
src={asImageSrc(image) ?? "/app/icons/typing.svg"}
alt="web development"
Expand Down
2 changes: 1 addition & 1 deletion app/routes/about.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default function About() {
<div className="relative flex justify-center">
<div className="absolute top-0 left-0 w-[80%] md:w-[60%] aspect-square bg-purple-radial-gradient-left z-[-1] "></div>
<div className="absolute bottom-0 right-0 w-[80%] md:w-[60%] aspect-square bg-pink-radial-gradient-right z-[-1] "></div>
<div className="w-[90%] md:max-w-[1100px]">
<div className="mt-24 md:mt-0 w-[90%] md:max-w-[1100px]">
<MainSection
tagline={asText(aboutData.about_pic_text)}
culture_description={asText(aboutData.culture_description)}
Expand Down
2 changes: 1 addition & 1 deletion app/routes/jumpstart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function Jumpstart() {
<div className="relative flex justify-center">
<div className="absolute top-[1%] md:top-0 left-0 w-[100%] md:w-[60%] aspect-square bg-purple-radial-gradient-left z-[-1] "></div>
<div className="absolute top-1/3 right-0 w-[100%] md:w-[60%] aspect-square bg-pink-radial-gradient-right z-[-1] "></div>
<div className="w-[90%] md:max-w-[1100px]">
<div className="mt-24 md:mt-0 w-[90%] md:max-w-[1100px]">
Copy link
Member

@amywng amywng Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top padding still doesn't match the other pages for me?

<JumpstartIntro
description={jumpStartData.description}
signUpLink={jumpStartData.signup}
Expand Down
2 changes: 1 addition & 1 deletion app/routes/partners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default function Clients() {
<div className="relative flex justify-center">
<div className="absolute top-0 left-0 w-[120%] md:w-[60%] aspect-square bg-purple-radial-gradient-left z-[-1]"></div>
<div className="absolute bottom-[45%] right-0 w-[120%] md:w-[60%] aspect-square bg-pink-radial-gradient-right z-[-1]"></div>
<div className="w-[90%] md:max-w-[1100px]">
<div className="mt-24 md:mt-0 w-[90%] md:max-w-[1100px]">
<PartnerHeader {...clientQuote} />
<h3 className="text-xl md:text-4xl mb-5 md:mb-8 font-medium">
Current Partner Organizations
Expand Down
2 changes: 1 addition & 1 deletion app/routes/people.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export default function People() {
return (
<div className="relative flex justify-center">
<div className="absolute left-0 w-[120%] md:w-[60%] aspect-square bg-pink-radial-gradient-left z-[-1]"></div>
<div className="w-[90%] md:max-w-[1100px]">
<div className="mt-24 md:mt-0 w-[90%] md:max-w-[1100px]">
<h1 className="mb-9 md:mt-[120px] md:mb-[72px] text-4xl md:text-5xl font-medium shrink-0 text-left">
Meet the <br className="block md:hidden" />
<span className="text-indigo-600">
Expand Down