16 payment integration setup stripe #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary documentation
Note: - USD is given in us cents - 50 cent minimum according to Stripe, we can reject here instead of letting that go to Stripe - Payment method types: card (debit or credit) and us bank accounts, covers most use cases - Payment method types could be more expansive (we could switch Stripe to self-determine accepted method types based on user characteristics) but it may not be worth it because it could require more frontend work for very rare edge cases.
…atch current invalid param checks for createPaymentIntent
…t will throw if Stripe API throws, also more realistic Stripe Success returns
Collaborator
|
Made very minor changes, let me know if it's all good to merge! |
Contributor
Author
|
Yes looks good, thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial Stripe configuration and Stripe service implementation.
Changes Made
interval) - apparently interval data is actually already stored within the priceThings mentioned in ticket that have not been implemented:
Testing & Verification
Unit tested with edge cases for parameter validation. Stripe mock returns realistic return objects and we validate how our code transforms that data to give flexible information to the user of these methods.
However, we have not tested integration with calling the real Stripe API, and have not tested in the Stripe test environment with using Stripe API keys in any way. Those are the next steps for this part of the project.
Future Improvements/Notes
PaymentIntentResponse and Create Subscription return object shapes are subject to change based on what is best needed for the frontend. PaymentIntentResponse is a larger object that enables more flexibility, while the Create Subscription return shape could be modified if there is more information needed.
While we return client secrets, we have not yet researched what these are used for. Only we know that these are usually used in modern Stripe implementations.
Testing in the Stripe test environment is necessary to ensure reliability and security. On the same note, not much security hardening has been done with this initial implementation so that is also a necessary next step.
Related Issues
Closes #16 Payment Integration Setup (Stripe)