Pk 65 adding buttons #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robpatterson13
left a comment
robpatterson13
left a comment
There was a problem hiding this comment.
Looks good to me! Just one small thing:
Comment on lines
29
to
39
| .card.back .card-text { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| text-align: center; | ||
| padding: 12px; | ||
| font-size: 16px; | ||
| line-height: 1.5; | ||
| height: 100%; | ||
| } | ||
|
|
There was a problem hiding this comment.
💭 It looks like this might be a change for GI-60 (I could be wrong though, let me know if I am!)
hams7504
reviewed
Feb 13, 2025
| <Input variant="filled" height="40px" width="100%" /> | ||
| </VStack> | ||
|
|
||
| const termsAndConditionsCheckboxesMap: CheckboxField[] = [ |
There was a problem hiding this comment.
Could you explain why this deletion was made?
hams7504
approved these changes
Feb 13, 2025
hams7504
left a comment
hams7504
left a comment
There was a problem hiding this comment.
Besides those 2 comments you may have to address, everything looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added buttons to the volunteer sign-up. I added Next, Back and Submit buttons to match the figma.
