Ns link signup form to backend #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hams7504
reviewed
Apr 9, 2025
hams7504
reviewed
Apr 9, 2025
hams7504
reviewed
Apr 9, 2025
| @@ -0,0 +1,4 @@ | |||
| export type SignUpDto = { | |||
There was a problem hiding this comment.
Could be a good idea to create a new folder at the apps directory which will house anything that both the frontend and backend need to share like DTOs. This is so that we can avoid repeated code.
Again, definitely don't need to do this in this PR. Just leaving this so we know for the future!
Author
There was a problem hiding this comment.
I'll probably wait on this one just so I can pull before I rewrite the imports on all the files!
hams7504
reviewed
Apr 9, 2025
|
Works great, thank you!! Checked that a new user was created in Cognito: Just need to resolve the comments + resolve any conflicts! |
|
looks good, just one more conflict! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://www.notion.so/mahekagg/GI-78-Connect-register-page-to-auth-endpoint-1998b3e6836e80ddb668e27a08bf28f0?pvs=4
📝 Description
Notes:
The backend endpoint is missing some important features, like telling the frontend if a user enters an invalid password or if an account exists. It's missing error handling.
Verification
Completed a successful signup using a mock user