implemented/tested delete_labels route #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amywng
requested changes
Aug 18, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
overall lgtm! left some comments
maxn990
reviewed
Aug 18, 2025
Member
maxn990
left a comment
maxn990
left a comment
There was a problem hiding this comment.
Looks good, I agree with Amy's comments :)
amywng
approved these changes
Aug 20, 2025
maxn990
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Issue #67
📝 Description
Added /delete_labels route to delete associated labels with a task entity.
This is deleting two labels from task 1. It had labelIds 1 and 3 associated with it, and we can see the results reflected in the join table.
And the following screenshots are for trying to access invalid/non-existent ids:
✔️ Verification
Created unit tests for both the service and controller layers, checking for invalid data types, and non-existent label/task ids.
NOTE: will probably update validation with validation pipe and DTO dedicated for both the delete and add label routes.