created navbar component #88
Conversation
|
If we aren't migrating frontend libraries this is ready to be reviewed again. |
rayyanmridha
left a comment
rayyanmridha
left a comment
There was a problem hiding this comment.
Looks good so far but there's a couple of things that should change
| description="All time submissions" | ||
| icon={usersIcon} | ||
| /> | ||
| <div className="flex flex-row"> |
There was a problem hiding this comment.
Is there anyway to add some sort of padding in between the navbar and main content? Currently, the cards and navbar look like they're touching each other.
| onChange?: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
| } | ||
|
|
||
| const SearchBar: React.FC<SearchBarProps> = ({ |
There was a problem hiding this comment.
Like Hannah mentioned, do we still need to use React.FC? The prop should still be typed directly as a regular function so it can be maintained easier.
rayyanmridha
left a comment
rayyanmridha
left a comment
There was a problem hiding this comment.
Accidentally highlighted the wrong piece of code in the last review but I corrected it now:
| href="#setting" | ||
| label="Setting" | ||
| icon={<IoIosSettings />} | ||
| /> |
There was a problem hiding this comment.
Change the label to be "Settings"
| href="#notification" | ||
| label="Notification" | ||
| icon={<FaBell />} | ||
| /> |
There was a problem hiding this comment.
Change the label to be "Notifications"
ℹ️ Issue
Closes #71
📝 Description
Created a usable component for the navbar
Briefly list the changes made to the code:
✔️ Verification
🏕️ (Optional) Future Work / Notes