-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-71] Frontend: Pantry application form #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
655d54d to
c061010
Compare
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments. Mostly styling changes, let me know if you have any questions :he-is-brighter:
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments!! 🍳
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes on how we handle the data
baa8316 to
3a7681e
Compare
dburkhart07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Go watch stranger things 🥑
fa368de to
1786323
Compare
sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New frontend looks great!
apps/backend/src/migrations/1763762628431-UpdatePantryFields.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/migrations/1763762628431-UpdatePantryFields.ts
Outdated
Show resolved
Hide resolved
sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't let me submit without filling in a secondary contact phone number :')
sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Priya about standardizing the multi-select UI since you and Justin had done it differently (I know the design you were working off of didn't originally specify). Would you be able to change yours to look like this, thanks! (this style looks the same as how it looks in the Figma for the food request form)

sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please leave a comment at digits.length <= 1 so other people know what's going on? LGTM after that!
ℹ️ Issue
Closes SSF-71
📝 Description
Fixed pantry app frontend to match Figma, added pantry app submission success route, verified submit application works to push data to pgadmin.
✔️ Verification
🏕️ (Optional) Future Work / Notes
Where should the cancel button take the user? Does any navigation need to be added to the submission success route so the user can get to where they want to go next?