Sk/ssf 82 pantry user refactoring #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amywng
requested changes
Nov 18, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
some minor comments, but other than that lgtm!
…m/Code-4-Community/ssf into sk/SSF-82-pantry-user-refactoring
amywng
approved these changes
Nov 20, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
small nit but approving, nice work!
dburkhart07
requested changes
Nov 22, 2025
apps/backend/src/migrations/1731171000000-UpdatePantryUserFields.ts
Outdated
Show resolved
Hide resolved
dburkhart07
approved these changes
Nov 23, 2025
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
One very last comment, but after that should be good!
apps/backend/src/migrations/1731171000000-UpdatePantryUserFields.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-82
📝 Description
Made backend changes to the pantry table/entity, updated the database/TypeORM entities, and other usages in code. Removed SSF representative, changed the name of the "pantry representative" to the "pantry user". Fixed the TODO in the pantry application modal (pantryApplicationModal.tsx) so the pantry user's info is shown in the modal.
✔️ Verification
Ran the database migration and verified the modal displays the correct user information through deploying app locally and accessing it on the frontend