SSF-57 Food Request Form Frontend #66
Conversation
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few small comments (see bug I also messaged you about on slack). Aside from this, looks good!
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Looks great so far, thanks for fixing the bug. Just a few small changes.
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
A few common styling changes to get the modal closer aligned to the Figma design, but aside from that looks good
SSF-57 Making up to date
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few final things to get it closer to the figma
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
I imagine when you change the text styles there will be a lot more space, so can you also fix that afterwards? Also, can we keep it more consistent by choosing either em or {#} for the margin across this file
Replacing em usages. Adding down icons to dropdowns, font refactoring
Also had to clean up missed code from removing donation id from orders that I accidentally added back in in my db enums pr
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
i'm a bit confused what the "resubmit latest order" modal is for. if it's for editing an existing order or submitting a new similar order, then we wouldn't want to disable editing and we should keep the continue button. if that's the case, you can ignore my comments related to the placeholders/color of text on that version of the modal. i would confirm its purpose with priya and change accordingly
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
One very small change to change something back. Aside from this, most of my comments Amy has already made, so address those and should be good!
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
beautiful, amazing, show-stopping, insert lady gaga clip here... thanks for taking my nits like a champ
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-57
📝 Description
This is a simple PR updating the frontend of the food request form to match the figma design here: https://www.figma.com/design/brc5luMhizIFp893XIutYe/FA25---SSF-Designs?node-id=1-1261&p=f&t=aRQ0y5CPAp6J73kE-0
The form can be found on request-form/1 (or whatever pantry id you desire).
✔️ Verification
I made sure the functionality of the request form stayed the same and it now matched the figma frontend design
Provide screenshots of any new components, styling changes, or pages.
