Skip to content

Conversation

@dburkhart07
Copy link

ℹ️ Issue

Closes #105

📝 Description

  • Adjusted the Role enum to combine both STANDARD_VOLUNTEER and LEAD_VOLUNTEER to just a VOLUNTEER role
  • Removed volunteer type filtering in the volunteer management
  • Performed migration to rewrite the database enum and its usage within the user table
  • Removed mentions of either role everywhere in the code

✔️ Verification

Verified all the endpoints still work:
image
image

Made sure volunteer management had the volunteer type removed:
image

Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it might be possible to update an enum type column by creating a new enum type, switching the column to use the new type, and then deleting the old enum, rather than dropping and re-adding the entire column (which would mess up dummy data). Can you look into this?

@dburkhart07 dburkhart07 requested a review from sam-schu December 7, 2025 15:35
@Juwang110 Juwang110 self-requested a review December 7, 2025 17:57
Copy link

@Juwang110 Juwang110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything lgtm!

Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

'food_manufacturer'
);
ALTER TABLE users
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we format this more readably or is Prettier making it look like this? (same for the down migration)

@dburkhart07 dburkhart07 requested a review from sam-schu December 27, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants