finished ruby collections#1
Open
ARSmith-prog wants to merge 5 commits intoCode-the-Dream-School:masterfrom
Open
finished ruby collections#1ARSmith-prog wants to merge 5 commits intoCode-the-Dream-School:masterfrom
ARSmith-prog wants to merge 5 commits intoCode-the-Dream-School:masterfrom
Conversation
|
Good work! You need to add some changes.
|
updated answer
updated answer
Author
|
Thank you, Here is my updated repo:
https://github.com/ARSmith-prog/Backend-ruby-collections/tree/ruby_3
Regards,
Alannah Smith
…On Sun, Apr 4, 2021 at 8:13 PM Iuliia-Shevtsova ***@***.***> wrote:
Good work! You need to add some changes.
1. Program in *sorted_words.rb* allows to enter just one word an print
it. The task says user should be able to to add as many words as they like,
until they just hit enter, and then print all words. So you need just add a
loop in your program.
2. Program in *add_up.rb* works great! But according the task function
add_up should has a parameter i that indicate the number. So it will
looks like add_up(i). You perfectly used the function with the
parameter in *leap_year.rb* program.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANFPOLVESXSQAUGG2AQSLMLTHD6EFANCNFSM42ETGJPA>
.
|
Comment on lines
+13
to
+14
| end | ||
| puts "Your Words Are: #{words.join(",")}" |
There was a problem hiding this comment.
You forgot to sort the array before print it out)
addded sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.