Open
Conversation
TurnerMooreDavis
left a comment
TurnerMooreDavis
left a comment
There was a problem hiding this comment.
LGTM! one small issue with leap_year
| @@ -0,0 +1,19 @@ | |||
| def add_up(i) | |||
| if (i.class !=Integer) || (i <1) | |||
| puts sum | ||
| end | ||
| end | ||
|
|
| @@ -0,0 +1,15 @@ | |||
| def Ask(question) | |||
| puts question | |||
| string = gets.chomp + " " | |||
There was a problem hiding this comment.
rather than adding a space to the end of the word here I would probably wait till the end of the method and just use join(' ')
| full_name.push(Ask("Enter your middle name, please")) | ||
| full_name.push(Ask("Enter your last name please")) | ||
|
|
||
| puts "Hello " + full_name[0] + full_name[1] + full_name[2] + "!" |
There was a problem hiding this comment.
sorta same as the above, I would use full_name.join(' ')
| end | ||
| end | ||
|
|
||
| year = begin_year |
There was a problem hiding this comment.
not sure what this line is doing. begin_year is not defined at this point
| @@ -0,0 +1,15 @@ | |||
| words = [] | |||
|
|
|||
| while true do | |||
There was a problem hiding this comment.
I try to avoid using while true loops, because then if any of the branches within that loop do not break correctly you end up with an infinite loop, which is no good
| word = gets.chomp | ||
| if word == '' | ||
| break | ||
| elsif word.index(/[^A-Za-z]/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.