Ruby collections lesson (Lesson 2.1)#8
Open
Dan88Hus wants to merge 2 commits intoCode-the-Dream-School:masterfrom
Open
Ruby collections lesson (Lesson 2.1)#8Dan88Hus wants to merge 2 commits intoCode-the-Dream-School:masterfrom
Dan88Hus wants to merge 2 commits intoCode-the-Dream-School:masterfrom
Conversation
ZipDevil
reviewed
Nov 16, 2021
| @@ -0,0 +1,28 @@ | |||
| # (1) Write a program which asks for a person's first name, then middle, then last. It should store each of these parts in an array. Finally, it should greet the person using their full name. Call the program full_name.rb. | |||
|
|
|||
There was a problem hiding this comment.
Good use of a Ruby hash for storing data.
| array.each do |i| | ||
| if i % 400 == 0 | ||
| puts i.to_s + ' is leap year' | ||
| elsif i % 4==0 && i % 100 != 0 |
There was a problem hiding this comment.
Watch for the indentation here, make sure all lines are aligned in the block.
| break if not swapped | ||
| end | ||
|
|
||
| array |
There was a problem hiding this comment.
Nice old-fashion way of sorting array elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.