Submit Lesson 2.1 assignment#9
Open
inlibra-cpa wants to merge 1 commit intoCode-the-Dream-School:masterfrom
Open
Submit Lesson 2.1 assignment#9inlibra-cpa wants to merge 1 commit intoCode-the-Dream-School:masterfrom
inlibra-cpa wants to merge 1 commit intoCode-the-Dream-School:masterfrom
Conversation
ZipDevil
reviewed
Nov 16, 2021
ZipDevil
left a comment
There was a problem hiding this comment.
Very clean code and good use of build-in methods.
| @@ -0,0 +1,6 @@ | |||
| def add_up(a) | |||
| sum = 0 | |||
| sum = (1..a).inject{ |s, i| s + i } | |||
| if starting_year % 4 == 0 | ||
| puts starting_year | ||
| elsif starting_year % 100 == 0 | ||
| elsif starting_year % 400 == 0 |
There was a problem hiding this comment.
For the conditional (if/else) statement, we like to start with edge cases and then other possibilities.
So here the if/else block would be:
if starting_year % 400 == 0
puts "#{starting_year} is leap year."
elsif starting_year % 4 = 0 && starting_yea % 100 != 0
puts "#{starting_year} is leap year."
end
Author
|
Thank you Jasper!
Appreciate it!
…On Tue, Nov 16, 2021, 10:57 Jasper Lin ***@***.***> wrote:
***@***.**** commented on this pull request.
Very clean code and good use of build-in methods.
------------------------------
In add_up.rb
<#9 (comment)>
:
> @@ -0,0 +1,6 @@
+def add_up(a)
+ sum = 0
+ sum = (1..a).inject{ |s, i| s + i }
Good use of inject here!
------------------------------
In leap_year.rb
<#9 (comment)>
:
> @@ -0,0 +1,14 @@
+puts "Enter starting_year"
+starting_year = gets.to_i
+puts "Enter ending_year"
+ending_year = gets.to_i
+puts ""
+while starting_year.to_i <= ending_year.to_i
+if starting_year % 4 == 0
+ puts starting_year
+elsif starting_year % 100 == 0
+elsif starting_year % 400 == 0
For the conditional (if/else) statement, we like to start with edge cases
and then other possibilities.
So here the if/else block would be:
if starting_year % 400 == 0
puts "#{starting_year} is leap year."
elsif starting_year % 4 = 0 && starting_yea % 100 != 0
puts "#{starting_year} is leap year."
end
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDMFNVD5BSU7GVNTBPQI7LUMJ5PRANCNFSM5HH3NHEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created multiple programs for Lesson 2.1:
full_name.rb
leap_year.rb
sorted_words.rb
add_up.rb