Skip to content

Limit redirects to relative URLs only #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limit redirects to relative URLs only #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions app/controllers/redirect_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
# Handle 301 redirects for pages that have changed location.
# NOTE: Only valid relative urls will be redirected for security reasons
# /foo, yes
# http://anothersite.com, no, redirects to /
# //anothersite.com, no, redirects to /
class RedirectController < ApplicationController

def index
return redirect_to(params[:url], :status => 301) if params[:url]
redirect_to '/'
if params[:url] && is_relative_url?(params[:url])
return redirect_to(params[:url], :status => 301)
else
redirect_to '/'
end
end

end
def is_relative_url?(url)
uri = URI.parse(url)
!uri.host && uri.path && uri.path != ''
rescue URI::InvalidURIError
false
end

end