CSV to JSON Project Take 2 #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change hyperkv back to hypercore temporarily Create framework for hyperkv Add add.js to lib Current work; move to cloud Make add.js in lib and create a test Add import method and test Finish work on delete case for hyperkv Change hyperkv to not use subleveldown when a db is provided Disabling iojs testing because of leveldown issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, my original solution didn't pass the first time. I wasn't aware that I needed to run "npm test" and make sure it passed. My bad.
Anyway, I ran "npm test" on my laptop, and it worked this time, so hopefully, my pull request will make it through.