Skip to content

Conversation

thejsj
Copy link
Member

@thejsj thejsj commented Feb 1, 2017

What this PR does

  • Fix seed script in order to create a context version and build for blank Dockerfile
  • Added trace as default logging

Integration Test

Please follow the guidelines presented in the How to Test an API PR
article when setting-up and performing tests.

  • Integration Tested @ commitsh by person_3 on (gamma|epsilon|staging)

thejsj added 11 commits January 13, 2017 17:04
* 'master' of github.com:CodeNow/api: (155 commits)
  11.22.2
  Revert "SAN-5654 GitHub Varnish" (#1869)
  11.22.1
  prepend http
  Fixed quote
  Added GITHUB_HOST env var
  Added github URL.
  11.22.0
  Updated to use GH varnish host + port.
  pull out the method make unit tests for it
  break out composeCheck function
  remove maxRetries
  add max tries to worker
  enable update cluster in auto-deploy fix unit tests add integration test
  11.21.13
  Way better design
  remove commented code
  remove opts from workerStopErrors Adding mainInstanceName to logging
  fixing more code to make the update work Adding more logging
  add autodeploy to the update fix that issue with updateInstance
  ...
* 'master' of github.com:CodeNow/api: (23 commits)
  11.22.9
  update version and shrinkwrap
  11.22.8
  Remove .log
  add error logger
  11.22.7
  Use cluster create
  Manual updating because shrinkwrap sucks
  11.22.6
  new workerStop
  Revert "new workerStop"
  new workerStop
  11.22.5
  whoops, didn't use the version
  add octobear
  Fixed tests I hope!
  11.22.4
  kill it with fire (#1872)
  11.22.3
  Updated to add GH host!
  ...
* 'master' of github.com:CodeNow/api:
  11.22.10
  ES6 change
  Added test
  Pr comments
  We shouldn't assume this is the only branch, not for MVP anyway
  Linting
  Created routes for runnable link in Jira
Copy link
Member

@Nathan219 Nathan219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super confused

let blankContext = res[1]
return createContextVersion(blankSource, blankContext, blankIcv)
.then(cv => {
return createAndBuildBuild(user, blankSource, cv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you making a build with the blank dockerfile? It shouldn't actually even work, since it's blank.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I needed to do to get this thing working. Basically, certain images need a context version to be based off (rethinkdb) and this solves that problem.

Myztiq and others added 11 commits February 1, 2017 16:12
* 'master' of github.com:CodeNow/api:
  11.23.1
  11.23.0
  Added unit tests
  remove unused files
  enable builds for public repos
  Testing
  Use different property to grab main instance
  Check if build is disabled before not setting appCodeVersion
  add compose files for tests
* 'bear-clone' of github.com:CodeNow/api:
  Added log
  Added options
  Added opts
  Added temp logging
  removed GH enterprise validation of emails
  Added new URL's
* 'master' of github.com:CodeNow/api: (40 commits)
  11.23.2
  SAN-5594 Cleanup
  SAN-5594 Passed reseting page size
  SAN-5594 Changed to expect the orgs instead of data.orgs
  SAN-5594 Yet more logging
  SAN-5594 More logging
  SAN-5594 More logging
  SAN-5594 Adding logging to track what is going on.
  SAN-5594 Another test forcing page size
  SAN-5594 Setting page size back to normal
  SAN-5594 Code review comment, deleting unused var
  SAN-5594 Removing console statement
  SAN-5594 Changes based on code review and temporary change to properly test it
  SAN-5594 Changes based on code review
  SAN-5594 reverting testing changes
  SAN-5594 testing on gamma, so temporary change to page size.
  SAN-5594 should finnaly be fixed
  SAN-5594 trying to debug the failed integration test
  SAN-5594 trying to debug the failed integration test
  SAN-5594 trying to debug the failed integration test
  ...
* 'master' of github.com:CodeNow/api: (262 commits)
  11.29.5
  11.29.4
  Fixed tests
  Poke
  Fixed unit tests
  Added logic to determine if currentContainer streaming
  Removed dep on dockerHost
  Added new unit tests.
  Bumped client again after merge conflcits
  Bumped client
  Added logic to stream old instances logs.
  11.29.3
  Updated api to use clio v1.0.7
  Updated api to use v 6
  Updated clio-client
  Updated clio version
  Updated client version
  Updated shrinkwrap
  Updated version of clio-client
  Updated shrinkwrap and package.json
  ...
@thejsj
Copy link
Member Author

thejsj commented Mar 20, 2017

How To Seed The database

  1. Login to API as HelloRunnable user in order to create the user in the mongo database

(Will move the document to the proper place when done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants