add more help on completing an arrow#24
Open
smason wants to merge 4 commits intoCodeReadingClubs:mainfrom
Open
add more help on completing an arrow#24smason wants to merge 4 commits intoCodeReadingClubs:mainfrom
smason wants to merge 4 commits intoCodeReadingClubs:mainfrom
Conversation
a lot of the CSS didn't seem to be doing much so removed it, then again it's been a while since I've done any fontend work
✅ Deploy Preview for crc-annotations ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
thanks for this! I really appreciate it |
danfishgold
requested changes
Jun 11, 2022
Collaborator
danfishgold
left a comment
danfishgold
left a comment
There was a problem hiding this comment.
just a couple of small notes :)
Author
|
thanks for the comments! replying down here instead of piecemeal:
|
danfishgold
reviewed
Jun 18, 2022
danfishgold
reviewed
Jun 18, 2022
not sure why I removed these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I struggled to understand what I was supposed to do when using the tool and it sounded like it's come up before
have tested locally under firefox and chrome and it seems to do the right thing
this is a somewhat hacky change, feel free to suggest alternatives!